feat(useAnchoredMenu): add hook #725

tenphi · 2025-07-15T17:23:18Z

No description provided.

changeset-bot · 2025-07-15T17:23:22Z

🦋 Changeset detected

Latest commit: c07963d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cube-dev/ui-kit	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-07-15T17:23:23Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cube-ui-kit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2025 3:52pm
cube-ui-kit-cursor	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2025 3:52pm

github-actions · 2025-07-15T17:24:14Z

📦 NPM canary release

Deployed canary version 0.0.0-canary-6ea7a04.

github-actions · 2025-07-15T17:24:48Z

🏋️ Size limit report

Name	Size	Passed?
All	262.27 KB (+0.3% 🔺)	Yes 🎉
Tree shaking (just a Button)	21.71 KB (0% 🟰)	Yes 🎉
Tree shaking (just an Icon)	11.4 KB (0% 🟰)	Yes 🎉

Click here if you want to find out what is changed in this build

github-actions · 2025-07-15T17:24:52Z

🧪 Storybook is successfully deployed!

👀 Review changes: https://www.chromatic.com/build?appId=626ee6db91d1c8004a912249&number=1864
👨‍🎨 Preview storybook: https://626ee6db91d1c8004a912249-cntpbceweh.chromatic.com/

Copilot

Pull Request Overview

This PR adds useAnchoredMenu hook functionality to provide menu anchoring capabilities for the UI component library. The implementation includes event bus-based menu synchronization to ensure only one menu can be open at a time across different components.

Creates a comprehensive event bus system for global menu synchronization
Implements useAnchoredMenu hook for anchoring menus to specific elements
Adds useContextMenu hook for context menus at pointer coordinates

Reviewed Changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/utils/react/useEventBus.ts	Implements event bus system with provider, hooks, and listener management
src/utils/react/sharedStore.ts	Adds shared store functionality for state management across hot reloads
src/components/actions/use-anchored-menu.tsx	Main useAnchoredMenu hook implementation with menu synchronization
src/components/actions/use-context-menu.tsx	Context menu hook with coordinate-based positioning
src/components/actions/Menu/MenuTrigger.tsx	Updates MenuTrigger to support event bus synchronization
src/components/fields/Select/Select.tsx	Integrates Select component with menu synchronization
src/components/fields/ComboBox/ComboBox.tsx	Integrates ComboBox component with menu synchronization
src/provider.tsx	Adds EventBusProvider to component provider chain
src/components/Root.tsx	Integrates EventBusProvider into Root component

Comments suppressed due to low confidence (1)

src/components/actions/Menu/Menu.test.tsx:1055

The useAnchoredMenu tests are comprehensive but missing error handling tests for the setup check functionality.

describe('useAnchoredMenu', () => {

src/utils/random.ts

src/utils/react/useEventBus.ts

src/components/actions/use-context-menu.tsx

src/components/actions/use-anchored-menu.tsx

src/utils/react/sharedStore.ts

src/components/actions/use-context-menu.test.tsx

Co-authored-by: Copilot <[email protected]>

cursor

Bug: Nested Providers Cause Event Bus Context Isolation

The Root component creates nested EventBusProvider instances. This occurs because Root directly wraps its children with EventBusProvider, and it also renders the Provider component, which similarly wraps its children with EventBusProvider. This duplication leads to separate event bus contexts, breaking menu synchronization as events are isolated to the innermost provider.

src/provider.tsx#L50-L52

cube-ui-kit/src/provider.tsx

Lines 50 to 52 in c07963d

    
           // Wrap with EventBusProvider for menu synchronization 
        
           children = <EventBusProvider>{children}</EventBusProvider>;

src/components/Root.tsx#L153-L158

cube-ui-kit/src/components/Root.tsx

Lines 153 to 158 in c07963d

    
           <PortalProvider value={ref}> 
        
             <EventBusProvider> 
        
               <NotificationsProvider rootRef={ref}> 
        
                 <AlertDialogApiProvider>{children}</AlertDialogApiProvider> 
        
               </NotificationsProvider> 
        
             </EventBusProvider>

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

tenphi added 8 commits July 15, 2025 14:42

feat(useAnchoredMenu): add hook

e869525

feat(useAnchoredMenu): add hook * 2

8462a35

feat(useAnchoredMenu): add hook * 3

62eabc4

feat(useEventBus): add hook

0d3275e

fix(Menu): only a single menu opened at a time

344615d

fix(Menu): only a single menu opened at a time * 2

776528a

fix: single popover logic

a11fb5b

fix: single popover logic * 2

87ec1b6

tenphi requested a review from Copilot July 15, 2025 17:23

tenphi deployed to Canary package in NPM July 15, 2025 17:23 — with GitHub Actions View deployment

tenphi deployed to Chromatic staging July 15, 2025 17:23 — with GitHub Actions View deployment

Copilot AI reviewed Jul 15, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

tenphi added 2 commits July 16, 2025 11:50

chore: add use-anchored-menu documentation and examples

bb97079

fix(useContextMenu): change implementation and add documentation

817746c

tenphi deployed to Chromatic staging July 16, 2025 10:42 — with GitHub Actions View deployment

tenphi deployed to Canary package in NPM July 16, 2025 10:42 — with GitHub Actions View deployment

vercel bot deployed to Preview – cube-ui-kit July 16, 2025 10:43 View deployment

vercel bot deployed to Preview – cube-ui-kit-cursor July 16, 2025 10:46 View deployment

This comment was marked as outdated.

Sign in to view

Update src/utils/random.ts

506f6d0

Co-authored-by: Copilot <[email protected]>

tenphi deployed to Canary package in NPM July 16, 2025 10:48 — with GitHub Actions View deployment

tenphi deployed to Chromatic staging July 16, 2025 10:48 — with GitHub Actions View deployment

vercel bot deployed to Preview – cube-ui-kit July 16, 2025 10:49 View deployment

fix(UseContextMenu): add return type

af1e08b

vercel bot deployed to Preview – cube-ui-kit-cursor July 16, 2025 12:45 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – cube-ui-kit July 16, 2025 12:46 View deployment

fix: menu second click

9275570

tenphi deployed to Chromatic staging July 16, 2025 14:02 — with GitHub Actions View deployment

tenphi had a problem deploying to Canary package in NPM July 16, 2025 14:02 — with GitHub Actions Failure

vercel bot deployed to Preview – cube-ui-kit July 16, 2025 14:03 View deployment

vercel bot deployed to Preview – cube-ui-kit-cursor July 16, 2025 14:06 View deployment

This comment was marked as outdated.

Sign in to view

chore: type fixes

bfbeaf4

tenphi deployed to Canary package in NPM July 16, 2025 14:19 — with GitHub Actions View deployment

tenphi deployed to Chromatic staging July 16, 2025 14:19 — with GitHub Actions View deployment

vercel bot deployed to Preview – cube-ui-kit July 16, 2025 14:20 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – cube-ui-kit-cursor July 16, 2025 14:23 View deployment

chore: update documentation

70b2d5a

tenphi deployed to Canary package in NPM July 16, 2025 14:49 — with GitHub Actions View deployment

tenphi deployed to Chromatic staging July 16, 2025 14:49 — with GitHub Actions View deployment

vercel bot deployed to Preview – cube-ui-kit-cursor July 16, 2025 14:51 View deployment

vercel bot deployed to Preview – cube-ui-kit July 16, 2025 14:52 View deployment

This comment was marked as outdated.

Sign in to view

fix(useContextMenu): api

c07963d

tenphi deployed to Chromatic staging July 16, 2025 15:49 — with GitHub Actions View deployment

tenphi deployed to Canary package in NPM July 16, 2025 15:49 — with GitHub Actions View deployment

vercel bot deployed to Preview – cube-ui-kit July 16, 2025 15:50 View deployment

vercel bot deployed to Preview – cube-ui-kit-cursor July 16, 2025 15:52 View deployment

tenphi merged commit 4b789d2 into main Jul 16, 2025
13 checks passed

tenphi deleted the use-anchored-menu branch July 16, 2025 15:53

github-actions bot mentioned this pull request Jul 16, 2025

Version Packages #726

Merged

cursor bot reviewed Jul 16, 2025

View reviewed changes


	// Wrap with EventBusProvider for menu synchronization
	children = <EventBusProvider>{children}</EventBusProvider>;

	<PortalProvider value={ref}>
	<EventBusProvider>
	<NotificationsProvider rootRef={ref}>
	<AlertDialogApiProvider>{children}</AlertDialogApiProvider>
	</NotificationsProvider>
	</EventBusProvider>

feat(useAnchoredMenu): add hook #725

feat(useAnchoredMenu): add hook #725

Uh oh!

Conversation

tenphi commented Jul 15, 2025

Uh oh!

changeset-bot bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 NPM canary release

Uh oh!

github-actions bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🏋️ Size limit report

Uh oh!

github-actions bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Storybook is successfully deployed!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Nested Providers Cause Event Bus Context Isolation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Jul 15, 2025 •

edited

Loading

vercel bot commented Jul 15, 2025 •

edited

Loading

github-actions bot commented Jul 15, 2025 •

edited

Loading

github-actions bot commented Jul 15, 2025 •

edited

Loading

github-actions bot commented Jul 15, 2025 •

edited

Loading